Differential D1657

Allow the user to save and print Terms and Conditions text
ClosedPublic
Actions

Authored by elexis on Oct 24 2018, 3:29 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP21919: Allow the user to print and save the text of the terms and conditions before…

Trac Tickets

#5257

Summary

So far we have implemented a traditional "clickwrap agreement".
The term must be mentioned, since its an industry standard and so that people can lookup the court decisions on that word:
https://en.wikipedia.org/wiki/Clickwrap

Test Plan

Notice that we have a version issue for users who play under older terms.
Instead of linking to trac, there should be a more maintained version on the backend.
Notice the Terms should be displayed without gui tags but html fonts online and including translations online, yikes.
This diff is a step into that direction and improves the current status quo, even if it doesn't go the entire length to fit the industry standard perfectly.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Oct 24 2018, 3:29 PM

elexis updated the Trac tickets for this revision.Oct 24 2018, 3:30 PM

Stan added a reviewer: Itms.Oct 24 2018, 3:30 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Default...
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/mod/gui/termsdialog/termsdialog.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/mod/gui/termsdialog/termsdialog.js
|  46|  46| function initLanguageSelection()
|  47|  47| {
|  48|  48| 	let languageLabel = Engine.GetGUIObjectByName("languageLabel");
|  49|    |-	let languageLabelWidth = Engine.GetTextWidth(languageLabel.font, languageLabel.caption)
|    |  49|+	let languageLabelWidth = Engine.GetTextWidth(languageLabel.font, languageLabel.caption);
|  50|  50| 	languageLabel.size = "0 0 " + languageLabelWidth + " 100%";
|  51|  51| 
|  52|  52| 	let languageDropdown = Engine.GetGUIObjectByName("languageDropdown");

binaries/data/mods/mod/gui/termsdialog/termsdialog.js
|  49| »   let·languageLabelWidth·=·Engine.GetTextWidth(languageLabel.font,·languageLabel.caption)
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.

Link to build: https://jenkins.wildfiregames.com/job/differential/754/display/redirect

Harbormaster completed remote builds in B6414: Diff 6948.Oct 24 2018, 3:35 PM

elexis edited reviewers, added: Restricted Owners Package; removed: Itms.Oct 24 2018, 3:38 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 25 2018, 2:32 PM

Closed by commit rP21919: Allow the user to print and save the text of the terms and conditions before… (authored by elexis). · Explain Why

This revision was automatically updated to reflect the committed changes.

Owners added a subscriber: Restricted Owners Package.Oct 25 2018, 2:32 PM