Page MenuHomeWildfire Games

Small LICENSE.txt cleanup
ClosedPublic

Authored by elexis on Nov 5 2018, 3:03 PM.

Details

Summary

The sentence from rP6911 should be updated to reflect that we ought to have most licensing information by now.
The pathnames look like unix format, but they aren't, since paths starting with / are considered absolute.

Test Plan

Check whether the first sentence of the document shouldn't be more conditional, as one can't generalize GPL v2+ features for the entire package.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Nov 5 2018, 3:03 PM
asterix accepted this revision.Nov 6 2018, 2:31 PM
asterix added a subscriber: asterix.

The text is correct. Thank you for the corrections.

This revision is now accepted and ready to land.Nov 6 2018, 2:31 PM
lyv added a subscriber: lyv.Nov 6 2018, 5:38 PM
lyv added inline comments.
LICENSE.txt
26 ↗(On Diff #6964)

Doesn't this imply that the code is also under the LICENSE.txt, or is that covered by L17?

elexis marked an inline comment as done.Nov 6 2018, 6:02 PM
elexis added inline comments.
LICENSE.txt
26 ↗(On Diff #6964)

Doesn't LICENSE.txt of that directoy explain the licensing within that directory?

lyv added inline comments.Nov 6 2018, 6:30 PM
LICENSE.txt
26 ↗(On Diff #6964)

Apparently so. The other directories are still kinda grey though, aren't they?
(there are height maps in there too.)

Stan added a reviewer: Itms.Dec 28 2018, 3:49 PM
Stan added a subscriber: Stan.

This looks good to me.

Stan retitled this revision from Small LICENES.txt cleanup to Small LICENSE.txt cleanup.Dec 28 2018, 3:49 PM
This revision was landed with ongoing or failed builds.Oct 22 2022, 8:29 PM
This revision was automatically updated to reflect the committed changes.