This is an import of commit https://github.com/premake/premake-core/commit/5f57b5d62a4518f391cf66e1cfb70e4a92353178 in our premake5 alpha10 copy.
See issue https://github.com/premake/premake-core/issues/1154 for more information.
Differential D1669
Remove hardcoded minimum OSX version in premake5 Itms on Nov 9 2018, 7:27 PM. Authored by
Details This is an import of commit https://github.com/premake/premake-core/commit/5f57b5d62a4518f391cf66e1cfb70e4a92353178 in our premake5 alpha10 copy. See issue https://github.com/premake/premake-core/issues/1154 for more information. Tested by @trompetin17 (running and bundling)
Diff Detail
Event TimelineComment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/772/ Comment Actions Can the -mmacosx-version-min=10.9 flag be replaced by a constant? To prevent those big changes to change a version. Comment Actions Yes, like Vlad says, we should change our own defaults in the premake scripts, but we mustn't touch premake source (it's easier to maintain when we match upstream). Comment Actions The source code actually has -mmacosx-version-min=10.4, so like i understand is that change to something like -mmacosx-version-min=${MIN_OSX_VERSION}? Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/778/ Comment Actions Regarding the premake5 change, it looks good, you could remove the offending line from build/premake/premake5/premake5.lua for completeness. I hope to get a quick answer on issue 1154.
Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/788/ Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/808/ Comment Actions Might I suggest to save this as a patch and apply it on premake when updating update workspaces on OsX ? Comment Actions We would do that if we were pulling premake from somewhere, but here we keep a copy of premake in the tree, so we should just patch that copy. Comment Actions I see. Won't be hard to keep track of all the patches we apply ? For now we only have one but we might have more in the future, no ? Comment Actions Yes, please read the discussion at https://github.com/premake/premake-core/issues/1154. The correct fix would be to upgrade to alpha13 of premake5, but the odds of breaking the build system are a bit high, so I'll upgrade after the release. |