Page MenuHomeWildfire Games

[Minor cleanup] Use typed arrays where possible and worth it.
Needs ReviewPublic

Authored by smiley on Nov 19 2018, 7:19 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Nothing ought to be changed. Except maybe a few micro seconds faster.

Test Plan

-

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

smiley created this revision.Nov 19 2018, 7:19 PM
smiley added inline comments.Nov 19 2018, 7:22 PM
binaries/data/mods/public/simulation/components/TerritoryDecay.js
11

CCmpTerritoryManager keeps it as u32

smiley added inline comments.Nov 19 2018, 7:57 PM
binaries/data/mods/public/simulation/components/TerritoryDecay.js
52

Not sure how this returns the data, probably as an untyped array.

smiley marked an inline comment as done.Jan 15 2019, 8:45 AM
smiley added inline comments.
binaries/data/mods/public/maps/random/rmgen/placer/centered/ChainPlacer.js
42

This seems like a sane change though.

binaries/data/mods/public/simulation/components/TerritoryDecay.js
11

I wonder why I did this in the first place.