Page MenuHomeWildfire Games

Cleanup RallyPointRenderer
Needs ReviewPublic

Authored by Stan on Sat, Nov 24, 5:25 PM.

Details

Reviewers
vladislavbelov
Summary

This is the first step for D557 before creating an abstract class.

Replace std::deque by std::vector
Replace some casts.
Includes D1681
Move the class and struct declaration to a separate file for clarity.

Test Plan

Test it doesn't break anything
Report any possible improvements in that class we can include.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 6468
Build 10708: Vulcan BuildJenkins

Event Timeline

Stan created this revision.Sat, Nov 24, 5:25 PM
Vulcan added a subscriber: Vulcan.Sat, Nov 24, 5:25 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/799/

Why separate header? I don't think it helps much. All other components don't have headers.

Stan added a comment.Sat, Nov 24, 5:42 PM

Cause that file is huge. Also I think it's good practise to do so.

Stan updated this revision to Diff 7005.Sat, Nov 24, 6:28 PM

Try to fix the build. Fix warnings.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/800/

Stan updated this revision to Diff 7006.Sat, Nov 24, 6:45 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/801/