updateSettingsPanelPosition is calling the engine on every tick even when is doing nothing. Fix it to make an early return when is doing nothing.
In my case the profiling gives an idle gui tick of 3.5 msec/frame and 0.9 msec/frame with fix.
Details
Details
Test that still works as intended and when the window resizes.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Comment Actions
The same thing may also be the case in the ingame thing which slides down.
| gui/gamesetup/gamesetup.js | ||
|---|---|---|
| 1249 ↗ | (On Diff #7042) | If offset would always be a number, there is no need for triple equals no? |
Comment Actions
The same thing may also be the case in the ingame thing which slides down.
Apparently, not.
function updateMenuPosition(dt)
{
let menu = Engine.GetGUIObjectByName("menu");
let maxOffset = g_IsMenuOpen ?
END_MENU_POSITION - menu.size.bottom :
menu.size.top - MENU_TOP;
if (maxOffset <= 0)
return;
let offset = Math.min(MENU_SPEED * dt, maxOffset) * (g_IsMenuOpen ? +1 : -1);
let size = menu.size;
size.top += offset;
size.bottom += offset;
menu.size = size;
}| gui/gamesetup/gamesetup.js | ||
|---|---|---|
| 1249 ↗ | (On Diff #7042) | I wrote it like this given that only the value 0 is meant to return true. I think that is shows better when this condition must be met and not some other similar although this might feel pedantic. |
| gui/gamesetup/gamesetup.js | ||
|---|---|---|
| 1249 ↗ | (On Diff #7042) | ! offset is only true if offset is 0 or does not exist. |
Comment Actions
And here the guy to blame :S, can't even put off the blame by saying it was copied from the main-menu or ingame menu...
offset always a number indeed. For me !offset suffices
Gui tick went down from 1.7ms to 0.4ms here, so absolutely worth changing this
The function is called twice and both cases could use this check, thus the position is correct
Change trivial => accept
Comment Actions
While committing thought of the programming.json: @nani please put your nick and if you want name in there and upload in a new patch on the revision so you are credited
Comment Actions
can't even put off the blame by saying it was copied from the main-menu or ingame menu...
So the error is addressed in one of three places?