Page MenuHomeWildfire Games

rename Kushite emblem for consistency
ClosedPublic

Authored by Nescio on Dec 28 2018, 1:52 PM.

Details

Summary

All civilization emblem names start with emblem_, the Kushite one is the only exception; this is now changed for consistency.
(Actually the emblem_ part is unnecessary and could be removed from all emblems. This patch implements the lesser change, though.)

Test Plan

Ought to be unproblematic.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6537
Build 10809: Vulcan BuildJenkins
Build 10808: arc lint + arc unit

Event Timeline

Nescio created this revision.Dec 28 2018, 1:52 PM
Owners added a subscriber: Restricted Owners Package.Dec 28 2018, 1:52 PM
Vulcan added a subscriber: Vulcan.Dec 28 2018, 1:53 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/838/

Itms accepted this revision.Dec 28 2018, 2:35 PM

I confirm that kush.json is the only place referencing the emblem, and I agree that it is way more simple to make the kush emblem follow the convention used for all the others.

This revision is now accepted and ready to land.Dec 28 2018, 2:35 PM
This revision was automatically updated to reflect the committed changes.