Page MenuHomeWildfire Games
Differential D1711

map preview naming consistency
AbandonedPublic
Actions

Authored by Nescio on Dec 28 2018, 2:53 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Most of the art/textures/ui/session/icons/mappreviews/ have snake_case filenames, however, a few have capitals, spaces, hyphens, or parentheses, which is inconsistent and potentially problematic. This patch renames those png map previews and updates their corresponding maps/ files accordingly.
Furthermore, the names of the sandbox map previews were not always obvious (e.g. sandbox-themacks.png), therefore this proposal also applies the sandbox_kushites.png naming scheme to the others for consistency.

[EDIT] mappreview renames:
Barcania (3).png → barcania.png
Introductory_Tutorial.png → introductory_tutorial.png
sandbox-thebritons.png → sandbox_britons.png
Sandbox - Carthaginians.png → sandbox_carthaginians.png
sandbox-thegauls.png → sandbox_gauls.png
Sandbox - Iberians.png → sandbox_iberians.png
sandbox-themacks.png → sandbox_macedonians.png
sandbox-themauryas.png → sandbox_mauryas.png
sandbox-thepersians.png → sandbox_persians.png
sandbox-theromans.png → sandbox_romans.png
sandbox-theseleucids.png → sandbox_seleucids.png
survivalofthefittest.png → survival_of_the_fittest.png
The Persian Gates.png → persian_gates.png
Tropical Island.png → tropical_island.png

Test Plan

Ought to be unproblematic.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6542
Build 10815: Vulcan BuildJenkins
Build 10814: arc lint + arc unit

Event Timeline

Nescio created this revision.Dec 28 2018, 2:53 PM
Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Dec 28 2018, 2:53 PM
Vulcan added a subscriber: Vulcan.Dec 28 2018, 4:37 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/839/

Harbormaster failed remote builds in B6542: Diff 7088!Dec 28 2018, 4:37 PM
Nescio mentioned this in D1342: Corrected Mauryans into Mauryas.Dec 28 2018, 5:46 PM
Itms requested changes to this revision.Jan 2 2019, 4:14 PM

This now needs a rebase after rP22005, sorry for that (I thought it would be better to plainly change mauryans to mauryas everywhere, to avoid mistakes as much as possible).

I cannot find the discussion again... but we had discussed the fact that map file names should be without spaces as much as possible. We couldn't reach an agreement on how to write the number of players in skirmishes (currently with (2) and the likes), but for this diff, I think it would be a no-brainer to rename the maps as sandbox_iberians.xml/pmp, following the same convention as chosen for the png files.

This revision now requires changes to proceed.Jan 2 2019, 4:14 PM
Nescio added a comment.Jan 3 2019, 10:27 AM

D1042 is about renaming map files (the spaces and special characters in file names are still problematic). This one is about the (new?) map preview names (art/), so it's related but separate.

Nescio updated this revision to Diff 7631.Mar 31 2019, 12:42 PM
Nescio retitled this revision from sandbox map preview naming consistency to map preview naming consistency.
Nescio edited the summary of this revision. (Show Details)
Nescio edited the test plan for this revision. (Show Details)
Nescio added a subscriber: Itms.

Updated.

Vulcan added a comment.Mar 31 2019, 12:44 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1140/display/redirect

Harbormaster completed remote builds in B7062: Diff 7631.Mar 31 2019, 12:44 PM
Nescio edited the summary of this revision. (Show Details)Mar 31 2019, 12:48 PM
Nescio edited the summary of this revision. (Show Details)Mar 31 2019, 12:51 PM
Nescio added a subscriber: Stan.Apr 20 2019, 5:15 PM

@Stan, perhaps you could review this? (@Itms seems to be busy.)

Stan added a reviewer: Gallaecio.Apr 20 2019, 9:11 PM

I don't really have the time now, sorry but maybe gallaecio does :)

Nescio removed a reviewer: Gallaecio.Apr 20 2019, 10:16 PM
Nescio added a subscriber: Gallaecio.

It's about file names in the art/ folder; I thought of you because you mentioned the art design document today.

Nescio mentioned this in D1936: Load damageTypes from "simulation/data/damagetypes"-files..Jun 1 2019, 5:36 PM
Nescio added a reviewer: Restricted Owners Package.Jul 6 2019, 5:33 PM
Nescio abandoned this revision.Jun 1 2020, 10:41 AM
Nescio removed a reviewer: Itms.
Nescio removed subscribers: Gallaecio, Itms.

The map preview art files naming is inconsistent and ideally ought to follow the https://trac.wildfiregames.com/wiki/ArtFileNamingConventions and be made to match the file names of the maps they belong to (rP23719). However, I won't be the one doing that.

Revision Contents
Changeset List

Diff 7088

View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/Sandbox - Carthaginians.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/Sandbox - Iberians.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/Sandbox%20-%20Carthaginians.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/Sandbox%20-%20Iberians.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox-thebritons.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox-thegauls.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox-themacks.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox-themauryans.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox-thepersians.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox-theromans.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox-theseleucids.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox_britons.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox_carthaginians.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox_gauls.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox_iberians.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox_macedonians.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox_mauryas.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox_persians.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox_romans.png

Loading...
View Options

binaries/data/mods/public/art/textures/ui/session/icons/mappreview/sandbox_seleucids.png

Loading...
View Options

binaries/data/mods/public/maps/scenarios/Sandbox - Britons.xml

Loading...
View Options

binaries/data/mods/public/maps/scenarios/Sandbox - Carthaginians.xml

Loading...
View Options

binaries/data/mods/public/maps/scenarios/Sandbox - Gauls.xml

Loading...
View Options

binaries/data/mods/public/maps/scenarios/Sandbox - Iberians.xml

Loading...
View Options

binaries/data/mods/public/maps/scenarios/Sandbox - Macedonians.xml

Loading...
View Options

binaries/data/mods/public/maps/scenarios/Sandbox - Mauryans.xml

Loading...
View Options

binaries/data/mods/public/maps/scenarios/Sandbox - Persians.xml

Loading...
View Options

binaries/data/mods/public/maps/scenarios/Sandbox - Romans.xml

Loading...
View Options

binaries/data/mods/public/maps/scenarios/Sandbox - Seleucids.xml

Loading...
Wildfire Games · Phabricator