Page MenuHomeWildfire Games

Fix rP21960
ClosedPublic

Authored by Itms on Dec 28 2018, 5:31 PM.

Details

Summary

In rP21960, I committed a fix to the files parsed by the pot extractor. I did not remove a filemask that is obsolete, this diff addresses this.

Test Plan

I took the opportunity to check if other filemasks were obsolete. I used the attached naive python script to do so. (There is probably a one-liner in Perl, but why spend days figuring it out...)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Itms created this revision.Dec 28 2018, 5:31 PM
Vulcan added a subscriber: Vulcan.Dec 28 2018, 6:49 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/844/

elexis accepted this revision.Dec 28 2018, 8:08 PM

Thanks for the diff. I hope it didn't cost too much time for the scripting (was it quicker than looking if the directories exist by hand/eye/grep?).

This revision is now accepted and ready to land.Dec 28 2018, 8:08 PM
Itms added a comment.Dec 28 2018, 8:14 PM
In D1714#67739, @elexis wrote:

was it quicker than looking if the directories exist by hand/eye/grep?.

Yes! My Python-fu is quicker than my mouse ๐Ÿ™

This revision was automatically updated to reflect the committed changes.