Page MenuHomeWildfire Games

manual/intro.txt corrections
ClosedPublic

Authored by Nescio on Sun, Dec 30, 3:43 PM.

Details

Reviewers
Stan
Summary
  • ForwardSlash → Slash
  • replaced hyphen itemization with bullets, because bullets are used earlier in the file, and to avoid confusion with the - key
  • removed a trailing white space
  • = key also works for zooming in
Test Plan

Ought to be unproblematic.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6605
Build 10894: Vulcan BuildJenkins
Build 10893: arc lint + arc unit

Event Timeline

Nescio created this revision.Sun, Dec 30, 3:43 PM
Owners added a subscriber: Restricted Owners Package.Sun, Dec 30, 3:43 PM
Stan accepted this revision.Sun, Dec 30, 3:45 PM

See I knew you would fix more stuff. Weren't those dashes in case someone tried to view it as markdown ?

This revision is now accepted and ready to land.Sun, Dec 30, 3:45 PM
Vulcan added a subscriber: Vulcan.Sun, Dec 30, 4:05 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/855/

See I knew you would fix more stuff.

Phabricator preview only shows a couple of lines, so when I open a file, I see other things too. (That doesn't mean I checked every line; undoubtedly this file contains more inconsistencies, a consequence of different people contributing.)

Weren't those dashes in case someone tried to view it as markdown ?

No idea; it's not a markdown file, and the itemizations in lines 12 to 34 use bullets.

Stan added a comment.Sun, Dec 30, 4:18 PM

Sure that's why we submit patches with more context ( Not always) Thanks for the fix :)

Stan added a comment.Sun, Dec 30, 5:06 PM

Fixed by rP21992 again the bot did not close it can you do it manually ? thanks

Am I doing something wrong?

Nescio closed this revision.Sun, Dec 30, 5:13 PM
elexis added a subscriber: elexis.Sun, Dec 30, 5:37 PM
In D1719#68110, @Nescio wrote:

Am I doing something wrong?

No, Stan is adding zero-width characters before the URL in the commit message.

binaries/data/mods/public/gui/manual/intro.txt
71

Just because I am curious, can someone explain me that change?

145

Are we refering to keyboard keys?

Nescio marked 2 inline comments as done.Mon, Dec 31, 12:27 PM
Nescio added inline comments.
binaries/data/mods/public/gui/manual/intro.txt
71

D1529 corrected BackSlash into Backslash. The / is properly called slash, solidus, or stroke; the "Forward" part is unnecessary and actually hypercorrect.

145

Yes, I believe so.

(I had personnaly never heard/read ForwardSlash before reading that diff :-). I didn't know the concept of hypercorrection, thanks.)
My main interrogation is was it considered to change in those other places refering to the same thing?
I guess there is a good argument to not have done it, the commiter may know better than us. (I can see a good reason).

elexis added inline comments.Mon, Dec 31, 1:21 PM
binaries/data/mods/public/gui/manual/intro.txt
71

Actually unrelated ramblings:

(KeyName.cpp defines a mapping from SDL keys to keynames that can be used in the pyrogenesis config: { SDLK_SLASH, "/", "ForwardSlash" }. But that doesn't necessarily mean that these strings must be used here.
Here the format should be whatever the reader and translators understands, so it's kind of arbitrary. I suppose ForwardSlash is a bit less ambiguous than Slash. (Otherwise I have no clue whats correct in that terms).)

(Other otherwise it's tragic that we need to keep N places in sync, default.cfg, options/hotkeys.json, intro.txt which if grouped per hotkey would allow mods to add new keys without having to replace the file, which in turn prevents launching of multiple mods simultanoeusly that add new entries, as they would overwrite the same file each. Refactoring was preemptively deemed bad so I ignored it, save my time and leave the problem to GUI modders.)