- ForwardSlash → Slash
- replaced hyphen itemization with bullets, because bullets are used earlier in the file, and to avoid confusion with the - key
- removed a trailing white space
- = key also works for zooming in
Details
- Reviewers
Stan
Ought to be unproblematic.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6605 Build 10894: Vulcan Build Jenkins Build 10893: arc lint + arc unit
Event Timeline
See I knew you would fix more stuff. Weren't those dashes in case someone tried to view it as markdown ?
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/855/
See I knew you would fix more stuff.
Phabricator preview only shows a couple of lines, so when I open a file, I see other things too. (That doesn't mean I checked every line; undoubtedly this file contains more inconsistencies, a consequence of different people contributing.)
Weren't those dashes in case someone tried to view it as markdown ?
No idea; it's not a markdown file, and the itemizations in lines 12 to 34 use bullets.
Sure that's why we submit patches with more context ( Not always) Thanks for the fix :)
(I had personnaly never heard/read ForwardSlash before reading that diff :-). I didn't know the concept of hypercorrection, thanks.)
My main interrogation is was it considered to change in those other places refering to the same thing?
I guess there is a good argument to not have done it, the commiter may know better than us. (I can see a good reason).
binaries/data/mods/public/gui/manual/intro.txt | ||
---|---|---|
71 | Actually unrelated ramblings: (KeyName.cpp defines a mapping from SDL keys to keynames that can be used in the pyrogenesis config: { SDLK_SLASH, "/", "ForwardSlash" }. But that doesn't necessarily mean that these strings must be used here. (Other otherwise it's tragic that we need to keep N places in sync, default.cfg, options/hotkeys.json, intro.txt which if grouped per hotkey would allow mods to add new keys without having to replace the file, which in turn prevents launching of multiple mods simultanoeusly that add new entries, as they would overwrite the same file each. Refactoring was preemptively deemed bad so I ignored it, save my time and leave the problem to GUI modders.) |