The descriptions of team bonuses were sometimes incorrect and sentences were often longer than necessary. This patch corrects mistakes and implements a standard format: [player] [class] [change] [attributes]. E.g.: "Allied warships −25% construction time." instead of "Ships construct 25% faster."
It also updates the team bonus descriptions listed in the civ.json files.
Details
Details
- Reviewers
Gallaecio - Commits
- rP22149: Improve team bonus descriptions consistency
Check for typos.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6609 Build 10900: Vulcan Build Jenkins Build 10899: arc lint + arc unit
Event Timeline
Comment Actions
BuildTime according to https://trac.wildfiregames.com/wiki/EnglishStyleGuide#Actions
- ships and siege engines are constructed
- structures are built
- technologies are researched
- units are trained
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/857/
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/859/
Comment Actions
Sounds pretty cool. Pinging @Gallaecio, @bb, and @elexis as it's still a big enough patch :)
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1121/display/redirect
Comment Actions
I really like the change, I just have some minor feedback for specific lines.
| binaries/data/mods/public/simulation/data/auras/teambonuses/mace_player_teambonus.json | ||
|---|---|---|
| 12 | Shouldn’t it be ‘Allied markets +20% sell prices.’? | |
| binaries/data/mods/public/simulation/data/auras/teambonuses/maur_player_teambonus.json | ||
| 10 | I would prefer this unrelated change not to be part of the patch, but if it does, I think this line should be last, assuming the new order is alphabetical. | |
| binaries/data/mods/public/simulation/data/auras/teambonuses/sele_player_teambonus.json | ||
| 12 | Centers | |
| binaries/data/mods/public/simulation/data/civs/mace.json | ||
| 85 | Same as above. | |
| binaries/data/mods/public/simulation/data/civs/sele.json | ||
| 84 | Same as above. | |
| binaries/data/mods/public/simulation/data/auras/teambonuses/mace_player_teambonus.json | ||
|---|---|---|
| 12 | No, that would imply this aura modifies the market, which isn't the case; barter prices are independent from specific structures. | |
| binaries/data/mods/public/simulation/data/auras/teambonuses/maur_player_teambonus.json | ||
| 10 | Attributes are typically listed in alphabetical order, but resources have are listed in the way they are numbered and displayed in-game (f, w, m, s, t). It is included in this patch because it's related. To start with,the current order of modifications is inconsistent with the practice of other teambonuses (e.g. brit), auras, technologies, and templates. | |
| binaries/data/mods/public/simulation/data/auras/teambonuses/sele_player_teambonus.json | ||
| 12 | You're right, I'll correct this. | |
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1139/display/redirect