Page MenuHomeWildfire Games

Wind speed computation speed-up
Needs ReviewPublic

Authored by wraitii on Dec 30 2018, 6:28 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

A followup patch to D78 and D359: speed up the wind computations for water.

Test Plan

Compile, review water maps.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
temp
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7599
Build 12390: Vulcan BuildJenkins
Build 12389: arc lint + arc unit

Event Timeline

wraitii created this revision.Dec 30 2018, 6:28 PM
Owners added a subscriber: Restricted Owners Package.Dec 30 2018, 6:28 PM
Vulcan added a subscriber: Vulcan.Dec 30 2018, 6:30 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/861/

wraitii updated this revision to Diff 8137.Sat, May 25, 8:21 PM
wraitii edited the summary of this revision. (Show Details)

Add some comments. This is actually quite sane and works correctly (and fixes an issue on Polynesia) so I'll commit it soon-ish.

Stan added a subscriber: Stan.Sat, May 25, 8:31 PM
Stan added inline comments.
source/renderer/WaterManager.cpp
1

Year.

1027

Can that happen ?

1041

1.0f ?

1044

Maybe it should be declared out of the scope ?

1052

Put comment on top ?

1059

spaces between operators.

1060

static_cast

Also can't you just use a normal a size_t ?

size_t m_MapSize;

1066

spaces between operators.

1067

Same here.

1072

spaces between operators.

1074

spaces between operators.

1075

Same here.

1079

can't this be 'simplified' using a ternary and a 'end' variable ?

1086

Comments start with caps.

1090

missing spaces ?

1103

1.0f ?

1106

spaces between operators.

1110

Missing braces.

1128

static_cast / why the cast ?

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1493/display/redirect