Details
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/861/
Add some comments. This is actually quite sane and works correctly (and fixes an issue on Polynesia) so I'll commit it soon-ish.
| source/renderer/WaterManager.cpp | ||
|---|---|---|
| 1 ↗ | (On Diff #8137) | Year. |
| 1027 ↗ | (On Diff #8137) | Can that happen ? |
| 1041 ↗ | (On Diff #8137) | 1.0f ? |
| 1044 ↗ | (On Diff #8137) | Maybe it should be declared out of the scope ? |
| 1052 ↗ | (On Diff #8137) | Put comment on top ? |
| 1059 ↗ | (On Diff #8137) | spaces between operators. |
| 1060 ↗ | (On Diff #8137) | static_cast Also can't you just use a normal a size_t ? size_t m_MapSize; |
| 1066 ↗ | (On Diff #8137) | spaces between operators. |
| 1067 ↗ | (On Diff #8137) | Same here. |
| 1072 ↗ | (On Diff #8137) | spaces between operators. |
| 1074 ↗ | (On Diff #8137) | spaces between operators. |
| 1075 ↗ | (On Diff #8137) | Same here. |
| 1079 ↗ | (On Diff #8137) | can't this be 'simplified' using a ternary and a 'end' variable ? |
| 1086 ↗ | (On Diff #8137) | Comments start with caps. |
| 1090 ↗ | (On Diff #8137) | missing spaces ? |
| 1103 ↗ | (On Diff #8137) | 1.0f ? |
| 1106 ↗ | (On Diff #8137) | spaces between operators. |
| 1110 ↗ | (On Diff #8137) | Missing braces. |
| 1128 ↗ | (On Diff #8137) | static_cast / why the cast ? |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1493/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/382/display/redirect
| source/renderer/WaterManager.cpp | ||
|---|---|---|
| 1079 ↗ | (On Diff #9335) | comments start with capital :) |
| source/renderer/WaterManager.cpp | ||
|---|---|---|
| 1027 ↗ | (On Diff #8137) | Yes before init. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/387/display/redirect
Ran some profiling, and I'm not actually sure this speeds things up. But it's still better behaviour as there are some artefacts with the existing code on e.g. Polynesia near the edges, and it's more readable imo so I'll commit anyways.