Page MenuHomeWildfire Games
Differential D1728

remove unnecessary gaia from other/ structures
ClosedPublic
Actions

Authored by Nescio on Jan 3 2019, 12:26 PM.

Details

Reviewers
Stan
Commits
rP22026: Remove unnecessary gaia from other/ structures
Summary

A follow-up to rP21975:

  • Removes <Civ>gaia</Civ> from the simulation/templates/other/ files because this is already present in template_structure.xml, from which these inherit (I don't remember why these other/ files were not included in D1645)
  • Also adds <Civ>gaia</Civ> to template_structure_defense_wallset.xml, because confusingly this file does *not* have a parent
Test Plan

Ought to be unproblematic

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jan 3 2019, 12:26 PM
Vulcan added a subscriber: Vulcan.Jan 3 2019, 12:27 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/889/

Harbormaster completed remote builds in B6674: Diff 7213.Jan 3 2019, 12:27 PM
Stan accepted this revision.Jan 5 2019, 4:34 PM
This revision is now accepted and ready to land.Jan 5 2019, 4:34 PM
Closed by commit rP22026: Remove unnecessary gaia from other/ structures (authored by Stan). · Explain WhyJan 5 2019, 4:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7271

View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/bench.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/bridge_hele.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/bridge_wooden.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/celt_hut.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/celt_longhouse.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/column_doric.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/column_doric_fallen.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/column_doric_fallen_b.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/desert_trading_post.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/fence_long.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/fence_short.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/fence_stone.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/generic_field.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/hellenic_epic_temple.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/hellenic_propylaea.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/hellenic_stoa.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/obelisk.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_angle_spike.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_rocks_curve.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_rocks_end.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_rocks_fort.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_rocks_gate.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_rocks_long.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_rocks_medium.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_rocks_outpost.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_rocks_short.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_rocks_straight.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_rocks_tower.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_rocks_watchtower.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_small_spikes.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/palisades_tall_spikes.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/sele_colonnade.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/stall_big.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/stall_med.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/stall_small_a.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/stall_small_b.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/table_rectangle.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/table_square.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/other/wallset_palisade.xml

Loading...
View Options

ps/trunk/binaries/data/mods/public/simulation/templates/template_structure_defense_wallset.xml

Loading...
Wildfire Games · Phabricator