This modification allows special filter templates to inherit from a parent. Instead of just loading the filter template directly onto the base filter, the filter template gets loaded and applied recursively with the new ApplyTemplateFilter method.
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Trac Tickets
- #5380
I tested the implementation roughly by having a filter template inheriting from another filter template and running the simulation successfully in Atlas. Before writing a unit test (unfortunately, there are no unit tests at all for the TemplateManager so far) and a more detailed test plan, I would like to ask if the current implementation is on the right way?
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Event Timeline
Add yourself to binaries/data/mods/public/gui/credit/programming.json. I might have messed up that path.
source/ps/TemplateLoader.cpp | ||
---|---|---|
76 | And L"special" / L"filter" instead of "special/filter/". | |
123 | I suppose the templateFilter should have the VfsPath. | |
126 | Why exactly 100? Probably it crashes even with this value on slower machines. The value should be a constant. Also why there are infinity loops? Why not to handle them? | |
134 | ok > result or even shorter: if (xero.Load(g_VFS, path) != PSRETURN_OK) return false; // ... |
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/521/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1949/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/ps/TemplateLoader.h | 44| class·CTemplateLoader | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCTemplateLoader{' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1951/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/macos-differential/525/display/redirect