Page MenuHomeWildfire Games

Remove <Actor> and <SpecificName> from generic templates.
Needs ReviewPublic

Authored by Nescio on Thu, Jan 24, 11:37 AM.

Details

Reviewers
Stan
Summary

The <SpecificName> and <Actor> values do not belong in the generic templates, they should be in the specific templates in the sub-folders.
This patch:

  • removes <Actor> from the generic template_* files
  • adds the appropiate actors to their specific children in the cases they were not yet included there
  • removes <SpecificName> from the generic template_* files
  • adds the appropiate specific names to their specific children in the cases they were not yet included there
  • removes <GenericName> from the gaia/ruins/* files
  • removes <GenericName> from the gaia/treasure/* files

<Actor> is still present in the following generic templates:

  • template_formation.xml
  • template_unit_catafalque.xml
Test Plan

Check for omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6830
Build 11229: Vulcan BuildJenkins
Build 11228: arc lint + arc unit

Event Timeline

Nescio created this revision.Thu, Jan 24, 11:37 AM
Vulcan added a subscriber: Vulcan.Thu, Jan 24, 11:39 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/992/

Stan added a comment.Thu, Jan 24, 11:57 AM

Thanks for the patch, I'll try to have more in depth look soon.

Stan added a reviewer: Stan.Thu, Jan 24, 11:58 AM