Page MenuHomeWildfire Games

Gaia templates' <Selectable> clean-up
Needs ReviewPublic

Authored by Nescio on Jan 26 2019, 2:36 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This patch:

  • removes <Selectable/EditorOnly/> from template_gaia.xml, because it's disabled in all its five children
  • sets <Selectable/Overlay> in template_gaia.xml and removes it from its children, because currently they all define similar overlays separately [EDIT]: standardize line thickness to 0.3 instead of 0.4 or 0.2
Test Plan

Probably unproblematic, but check nevertheless.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7126
Build 11631: Vulcan BuildJenkins
Build 11630: arc lint + arc unit

Event Timeline

Nescio created this revision.Jan 26 2019, 2:36 PM
Vulcan added a subscriber: Vulcan.Jan 26 2019, 3:02 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1004/

bb added a subscriber: bb.Mar 16 2019, 5:52 PM
bb added inline comments.
binaries/data/mods/public/simulation/templates/template_gaia_flora.xml
24

Overlay != Outline

36–40

how is that redundant?

binaries/data/mods/public/simulation/templates/template_gaia_treasure.xml
32

0.4!=0.3

Nescio added inline comments.Mar 16 2019, 10:18 PM
binaries/data/mods/public/simulation/templates/template_gaia_flora.xml
24

True, but effectively both overlay and outline result in a circle:


Therefore I assumed standardizing it for all gaia templates would be a good idea.
For comparison, structures have an outline with thickness 0.4, units use overlays. A tree does not move and is thus more similar to a structure than an unit.

36–40

Actually I'm not entirely sure why I removed this in January. Does it actually do anything, though?

binaries/data/mods/public/simulation/templates/template_gaia_treasure.xml
32

True, but is the value difference really significant? Standardizing the thickness is not necessarily bad.

Nescio updated this revision to Diff 7553.Mar 16 2019, 11:05 PM
Nescio edited the summary of this revision. (Show Details)

Updated because of rP22115.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1096/display/redirect

bb added inline comments.Sat, Apr 6, 11:48 PM
binaries/data/mods/public/simulation/templates/template_gaia_fish.xml
39

That would mean doubling the width...

refs rP18014

binaries/data/mods/public/simulation/templates/template_gaia_flora.xml
24

Comparing patched vs unpatched gives a clear difference between them: and outline gives an n-gon, while the texture gives a smooth circle. This is not really noticeable for mines, since they have a large radius, but for trees it is quite clear.

unpatched:

patched:

binaries/data/mods/public/simulation/templates/template_gaia_treasure.xml
32

yes, since 0.3 => 0.4 is a change of 33%, which surely is noticable, also please notice rP11672

On line thickness: yes, the difference between 0.2, 0.3, and 0.4 is noticable when looking at it closely, but is it important, does the exact thickness convey information to the human player? To me it seems these values are arbitrarily chosen, therefore setting one default value won't cause harm; cf. template_structure.xml.

Nescio updated this revision to Diff 7691.Sun, Apr 7, 11:17 AM
Nescio edited the summary of this revision. (Show Details)

Build is unstable, some tests have failed - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1177/display/redirect

Nescio updated this revision to Diff 7692.Sun, Apr 7, 11:31 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1178/display/redirect

Stan added a comment.Mon, Apr 8, 4:44 PM

*Takes the artistic cap*

As an artist as long as it looks good and circular (the jaggy line won't do it), it doesn't matter much what thickness it has, because it won't affect the player as those resources are equally valuable.

*Takes the programmer cap*

Less duplication sounds nice. I wonder if there is any performance impact in increasing the thickness and/or changing overlay to outline. One could test with a map like Two Seas (6) by selecting a few thousand trees.