Currently when you modify Health.js in another diff, you get a lot of error spam from vulkan, which is annoying.
Details
- Reviewers
Vulcan elexis - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP22075: Health.js cleanup. Fixes Vulkan complaints
Ought to be unproblematic
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1014/
Fix Vulkan warnings in Health.js
Vulcan should accept then.
Only checked for syntax styling completeness briefly, I suppose one could change every var to let, they're not so many and maybe not many merge conflicts resulting from this, and those that do result are easy to solve.
binaries/data/mods/public/simulation/components/Health.js | ||
---|---|---|
99 ↗ | (On Diff #7420) | good |
114 ↗ | (On Diff #7420) | yes |
225 ↗ | (On Diff #7420) | legit, because the first statement that would come after this fall-through would be the break statement |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1019/
(Get it over with, you replaced the var/let correctly, the rest is accepted by me, and ask Vulcan for the rest. There are no changes that can break anything.)
binaries/data/mods/public/simulation/components/Health.js | ||
---|---|---|
278 ↗ | (On Diff #7427) | Actually I think if we change it to /** then the jsdoc connotation is that this comment relates to the next function (http://usejsdoc.org/about-block-inline-tags.html), but the intention of the comment is to speak about all functions below. (Technically there aren't any private functions either, all are publicly accessible. ) There's only @file in jsdoc that relates to everything, but I didn't find anything quickly that relates to some of the functions below. |