Currently when you modify Health.js in another diff, you get a lot of error spam from vulkan, which is annoying.
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
- rP22075: Health.js cleanup. Fixes Vulkan complaints
Ought to be unproblematic
Fix Vulkan warnings in Health.js
Vulcan should accept then.
Only checked for syntax styling completeness briefly, I suppose one could change every var to let, they're not so many and maybe not many merge conflicts resulting from this, and those that do result are easy to solve.
|99 ↗||(On Diff #7420)|
|114 ↗||(On Diff #7420)|
|225 ↗||(On Diff #7420)|
legit, because the first statement that would come after this fall-through would be the break statement
(Get it over with, you replaced the var/let correctly, the rest is accepted by me, and ask Vulcan for the rest. There are no changes that can break anything.)
|278 ↗||(On Diff #7427)|
Actually I think if we change it to /** then the jsdoc connotation is that this comment relates to the next function (http://usejsdoc.org/about-block-inline-tags.html), but the intention of the comment is to speak about all functions below. (Technically there aren't any private functions either, all are publicly accessible. ) There's only @file in jsdoc that relates to everything, but I didn't find anything quickly that relates to some of the functions below.