Currently fish is a child of template_unit_fauna.xml; however, fish does not move, has no armour, attack, or health, and disables a few other things as well. In many ways fish is much more similar to gaia objects such as metal mines or fruit trees.
This proposal moves fish to template_gaia_fish.xml and adjust all fish templates accordingly.
Details
Check if nothing is overlooked.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1041/
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1042/
Idea seems good.
Opening a map with fish on it throws a bunch of errors (invalid template)
binaries/data/mods/public/simulation/templates/gaia/fauna_fish_tilapia.xml | ||
---|---|---|
4–6 ↗ | (On Diff #7454) | This indeed seems better, the identity description is false either way |
binaries/data/mods/public/simulation/templates/template_gaia_fish.xml | ||
9 ↗ | (On Diff #7454) | SeaCreature Animal Organic -ConquestCritical |
19 ↗ | (On Diff #7454) | k docks |
binaries/data/mods/public/simulation/templates/template_gaia_fish.xml | ||
---|---|---|
9 ↗ | (On Diff #7454) | Its new parent (gaia) does not have ConquestCritical, therefore it doesn't need to be removed. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1093/display/redirect
Game works, Atlas works changes make sense => accept
binaries/data/mods/public/simulation/templates/template_gaia_fish.xml | ||
---|---|---|
9 ↗ | (On Diff #7454) | The conclusion seems right, trees don't have organic either, so that excludes that one. Animal seems counterpart of Human, so leaving them out looks ok on second sight. (You were already right about conqestcritical) |
14 ↗ | (On Diff #7454) | kindof sad that this duplicates these values, nothing to do about that I suppose (anytime someone could create a gaia food harvest place in need of these values) |