Page MenuHomeWildfire Games

Delete unused technologies
ClosedPublic

Authored by Nescio on Feb 7 2019, 5:52 PM.

Details

Reviewers
wraitii
Commits
rP23770: Delete unused technologies.
Trac Tickets
#3800
Summary

This patch deletes dozens of unused technologies (checked with grep -r); they're probably a leftover from when they're deprecated in an earlier version of 0 A.D. years ago. Anyway, there is no point in maintaining them, hence this patch.

Test Plan

Check for completeness

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Feb 7 2019, 5:52 PM
Vulcan added a subscriber: Vulcan.Feb 7 2019, 5:56 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:

Link to build: https://jenkins.wildfiregames.com/job/differential/1051/

One ticket about this. #3800

Nescio updated this revision to Diff 7468.Feb 7 2019, 6:34 PM
Nescio updated the Trac tickets for this revision.

Thank you, Polakrity. Two more.

Vulcan added a comment.Feb 7 2019, 6:35 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:

Link to build: https://jenkins.wildfiregames.com/job/differential/1052/

elexis added a comment.Feb 8 2019, 7:32 PM

(refs "treasure" and "design documents" / "design document repository")

Nescio added a comment.Feb 8 2019, 8:04 PM

(refs "treasure" and "design documents" / "design document repository")

?

Stan added a comment.Feb 8 2019, 8:07 PM

I guess that's somehow meaning that we should check design documents before deleting stuff.

Nescio added a comment.Feb 8 2019, 8:14 PM

Where can those be found?

wraitii added a reviewer: Restricted Owners Package.Apr 22 2019, 9:23 AM
wraitii edited reviewers, added: wraitii; removed: Restricted Owners Package.Sep 1 2019, 4:29 PM
Nescio added a comment.Jun 7 2020, 1:49 PM

@wraitii, when you have time, this would still be a nice clean-up.

wraitii updated this revision to Diff 12204.EditedJun 7 2020, 5:29 PM

I believe you were missing: siege_packing, training_levy_cavalry and training_levy_infantry from some pairs.

Otherwise I've found the same unused technologies as you.
I don't think we're losing much by deleting much - they had some useful translations, perhaps, but it seems like it wouldn't be too difficult to go back and use them again in the future.

I will commit this in a few days to avoid too many breakages. Thanks for bringing it up again.


I believe the pairs were dropped in rP15713

Owners added a subscriber: Restricted Owners Package.Jun 7 2020, 5:29 PM
Vulcan added a comment.Jun 7 2020, 5:30 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2362/display/redirect

Nescio added a comment.Jun 7 2020, 9:06 PM

I believe you were missing: siege_packing, training_levy_cavalry and training_levy_infantry from some pairs.

Thanks, you're right. persians/training_levy_cavalry and persians/training_levy_infantry are used, but indeed training_levy_cavalry and training_levy_infantry are not, and I missed siege_packing too (introduced in rP13080, deprecated in rP15713).

This revision was not accepted when it landed; it landed in state Needs Review.Jun 14 2020, 11:10 AM
This revision was landed with ongoing or failed builds.
Closed by commit rP23770: Delete unused technologies. (authored by wraitii). · Explain Why
This revision was automatically updated to reflect the committed changes.