This patch deletes dozens of unused technologies (checked with grep -r); they're probably a leftover from when they're deprecated in an earlier version of 0 A.D. years ago. Anyway, there is no point in maintaining them, hence this patch.
Details
- Reviewers
wraitii - Commits
- rP23770: Delete unused technologies.
- Trac Tickets
- #3800
Check for completeness
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Link to build: https://jenkins.wildfiregames.com/job/differential/1051/
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Link to build: https://jenkins.wildfiregames.com/job/differential/1052/
I guess that's somehow meaning that we should check design documents before deleting stuff.
I believe you were missing: siege_packing, training_levy_cavalry and training_levy_infantry from some pairs.
Otherwise I've found the same unused technologies as you.
I don't think we're losing much by deleting much - they had some useful translations, perhaps, but it seems like it wouldn't be too difficult to go back and use them again in the future.
I will commit this in a few days to avoid too many breakages. Thanks for bringing it up again.
I believe the pairs were dropped in rP15713
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2362/display/redirect
I believe you were missing: siege_packing, training_levy_cavalry and training_levy_infantry from some pairs.
Thanks, you're right. persians/training_levy_cavalry and persians/training_levy_infantry are used, but indeed training_levy_cavalry and training_levy_infantry are not, and I missed siege_packing too (introduced in rP13080, deprecated in rP15713).