For the record once we move to SM45 might be interesting https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap
Add and fix documentation. The current one was incorrect.
Differential D1776
Cleanup Timer.js and update documentation Stan on Feb 8 2019, 11:31 AM. Authored by
Details
For the record once we move to SM45 might be interesting https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WeakMap Add and fix documentation. The current one was incorrect. Ought to be unproblematic. Check for completeness
Diff Detail
Event TimelineComment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... Executing section JS... binaries/data/mods/public/simulation/components/Timer.js | 59| » if·(typeof·repeattime·!=·"number"·||·!(repeattime·>=·0)) | | [NORMAL] JSHintBear: | | Confusing use of '!'. Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1053/ Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/1054/
Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/1082/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/1143/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/1215/display/redirect Comment Actions You forgot to put the full context to the diff. Now that you have changed the check in SetInterval,
Comment Actions @Polakrity sorry I never saw your answer hence why you never got one.
Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/542/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1056/display/redirect
Comment Actions
Just the question about the cmpTimer.
Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/macos-differential/570/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1990/display/redirect Comment Actions linter happy, bb happy
|