Page MenuHomeWildfire Games

Move map data to settings.js
Needs ReviewPublic

Authored by nani on Feb 10 2019, 4:18 AM.


Group Reviewers
Restricted Owners Package(Owns No Changed Paths)

Map type path data and filter should be in settings.js
Needed for D1703: Map browser for gamesetup

Test Plan

Keep same behaviour as before.

Diff Detail

Lint Skipped
Unit Tests Skipped

Event Timeline

nani created this revision.Feb 10 2019, 4:18 AM
nani added a parent revision: D1703: Map browser for gamesetup.
nani edited the summary of this revision. (Show Details)Feb 10 2019, 4:26 AM
nani updated this revision to Diff 7479.Feb 10 2019, 8:38 PM
elexis added a subscriber: elexis.Feb 16 2019, 9:32 PM
  • MapFilter: Wondering if this should remain in gamesetup/, since the purpose of settings.js to contain data that is used by multiple GUI pages. But it seems to pass that test, because similarly to the other data in settings.js, this could be used for example in the replay menu or lobby to filter games by maps too (at least if the map exists on the local computer). As mentioned in D1703, it would be better to specify the mapfilters JSON (using MatchClasses syntax) rather than JS. But I have a patch for that somewhere, and it could be considered independent.
  • MapType: Good idea, it never occured to me!
wraitii added reviewers: Restricted Owners Package, wraitii.Apr 22 2019, 9:34 AM