More aura icons
AbandonedPublic
Actions

Authored by Nescio on Feb 11 2019, 10:53 AM.

Details

Reviewers

Stan

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

This patch adds more aura icons, which could be useful for future auras (and mods).

renamed:
- attack_bonus.png → attack.png
- build_bonus.png → build.png
- buildgather_bonus.png → buildgather.png
- updated structure and unit auras to keep using the old icons (but not heroes and catafalques)
mirrored:
- health_bonus.png
created:
- bonus.png and penalty.png
- attack_bonus.png and attack_penalty.png
- build_bonus.png and build_penalty.png
- buildgather_bonus.png and buildgather_penalty.png
- grain_bonus.png and grain_penalty.png
- meat_bonus.png and meat_penalty.png
- metal_bonus.png and metal_penalty.png
- population_bonus.png and population_penalty.png
- stone_bonus.png and stone_penalty.png
- trade_bonus.png and trade_penalty.png
- eight coloured hearts

Images are based upon existing aura and resource icons.

Test Plan

Check if the file moves are done properly.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 6913
Build 11328: Vulcan Build	Jenkins
Build 11327: arc lint + arc unit

Event Timeline

Nescio created this revision.Feb 11 2019, 10:53 AM

Owners added a subscriber: Restricted Owners Package.Feb 11 2019, 10:53 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1056/

Harbormaster completed remote builds in B6913: Diff 7483.Feb 11 2019, 10:56 AM

Nescio edited the summary of this revision. (Show Details)Feb 11 2019, 11:01 AM

nani awarded a token.Feb 11 2019, 10:03 PM

Maybe instead of having a new icon for each bonus and penalty could be sprite combination of icon + bonus or icon + penalty combined? (would also make it easier to add new ones with less effort on the art side)

Basically that's what I did manually. To create _bonus and _penalty versions, I simply made two copies of the icon, pasting the bonus sprite on top of one and the penalty sprite on top of the other; costs about a minute, not much effort. And the icons are only a few kb each, so space is not really an issue.

In D1778#72067, @Nescio wrote:

Basically that's what I did manually. To create _bonus and _penalty versions, I simply made two copies of the icon, pasting the bonus sprite on top of one and the penalty sprite on top of the other; costs about a minute, not much effort. And the icons are only a few kb each, so space is not really an issue.

Yeah that is one way but I meant it like this.

E.g. : sprites.xml

<sprites>
    <sprite name="iconBuildgather">
        <image
            texture="art/textures/ui/session/auras/attack.png"
            size="0 0 100% 100%"
        />
    </sprite>

    <sprite name="iconBuildgatherBonus">
        <image
            texture="art/textures/ui/session/auras/attack.png"
            size="0 0 100% 100%"
        />
        <image
            texture="art/textures/ui/session/auras/bonus.png"
            size="50%+4 0%+4 100%-4 50%-4"
        />
    </sprite>

    <sprite name="iconBuildgatherPenalty">
        <image
            texture="global/icon/reset.png"
            size="0 0 100% 100%"
        />
        <image
            texture="art/textures/ui/session/auras/penalty.png"
            size="0%+4 0%+4 50%-4 50%-4"
        />
    </sprite>
</sprites>

Then is much easier add new iconBuildgatherFoo to the ones you want , change position or even change color with <effect add_color="R G B"/>

What do you think?

Well, I'm not a programmer, my understanding of code is rather limited, nor do I have any idea how superimposing icons might affect performance. Feel free to propose a separate patch for it, if you think that'll be an improvement.
Two things, though:

currently icon paths are hard-coded in aura .json files, e.g. "overlayIcon": "art/textures/ui/session/auras/buildgather_bonus.png",
most sprites are 128×128 pixels, but the resource icons are 64×64

Nescio added a reviewer: Restricted Owners Package.Jul 6 2019, 4:36 PM

It would be nice if all the auras icons had the sazme size. See those in art_source\trunk\art\textures\ui\guibackup there are 128x128 icons for resources there.

EDIT: Not sure about the use of colored hearts.

This revision now requires changes to proceed.Mar 8 2020, 10:55 AM

The problem is the 128×128 files in the art_source (left) look different from the 64×64 resource icons (centre) and 32×32 cursors (right) in the public folder: