Page MenuHomeWildfire Games

Technology icon consistency
ClosedPublic

Authored by Nescio on Feb 16 2019, 11:02 AM.

Details

Reviewers
Stan
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22126: Mirror (flips horizontally) five technology icons to ensure that all melee…
Summary

This patch mirrors (flips horizontally) five technology icons to ensure that all melee icons have the same orientation (bottom-left to top-right) and ranged a different one (bottom-right to top-left). E.g.:

(spear) and
(armor_plates_spear), but:
(armor_plates_iron_spear)
which is changed into:

[EDIT]: Also mirrored the structures/range icon.

Test Plan

Ought to be unproblematic.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Feb 16 2019, 11:02 AM
Owners added a subscriber: Restricted Owners Package.Feb 16 2019, 11:02 AM
Vulcan added a subscriber: Vulcan.Feb 16 2019, 11:39 AM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:

Link to build: https://jenkins.wildfiregames.com/job/differential/1058/

Nescio updated this revision to Diff 7523.Thu, Mar 7, 10:15 AM
Nescio edited the summary of this revision. (Show Details)

Also mirrored the structures/range icon.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:

Link to build: https://jenkins.wildfiregames.com/job/differential/1083/display/redirect

Stan added a comment.Thu, Mar 7, 11:33 AM

Wouldn't it better to have everything on the same direction ?

Stan added a reviewer: Restricted Owners Package.Thu, Mar 7, 11:33 AM

Having one direction for all melee weapons and a different one for all ranged weapons makes it easier to see if something is an arrow/ranged or a spear/melee.

elexis added a subscriber: elexis.Thu, Mar 7, 2:47 PM

Nice idea. I suppose most players won't notice, which could be addressed with a gameload hint. Also it's likely that the next best icon will be committed with a random direction, which could be addressed by posting a hint in some kind of place that artists have to go through to commit a new icon. I guess there is none such place. One can post some comments at some related files (parent template somewhere? portrait schema?), so some of the artists might remember and inform the other artists.
Or perhaps one can make them all face the same direction and mirror it using a tag in the XML/JS code if it's Ranged/Melee (or if AttackType.MirroredPortrait). (Or whatever.)

Stan added a comment.Thu, Mar 7, 7:16 PM

For the right place for Artist conventions one could either create a new wiki page called ArtConventions or edit the Art Design Document.

What about capturing technologies if any are they melee ?

What about capturing technologies if any are they melee ?

Which ones?

Nice idea.

Thanks. Personally I'd also prefer it if unit portraits would be standardized to use one orientation for melee units and a different one for ranged units, to make it easier to distinguish between e.g. spearmen and javelinists; however, that's outside the scope of this patch.

Stan added a comment.Fri, Mar 8, 10:36 AM

I was talking generally if you add a technology to boost capturing which would probably be a flag or something with corner should it point to ?

It depends what it is. E.g. clenched_fist.png is pointed upright, as are the parade_of_daphne.png flags. If a capture attack technology is introduced, I guess using the laurel_wreath.png icon makes sense.
Orientation can help to distinguish e.g. a throwing axe from a battle axe, but there is no point in enforcing something on things that aren't weapons.

Stan accepted this revision.Sun, Mar 17, 5:48 PM
This revision is now accepted and ready to land.Sun, Mar 17, 5:48 PM
This revision was automatically updated to reflect the committed changes.