Page MenuHomeWildfire Games

rename template_unit_fauna_decorative to template_bird
ClosedPublic

Authored by Nescio on Mar 16 2019, 9:56 PM.

Details

Summary

template_unit_fauna_decorative.xml has no parent, therefore its current name is misleading. Furthermore, it doesn't make sense to define values only to have them replaced or disabled by its only one child (gaia/fauna_hawk.xml).
This patch:

  • moves the template to template_bird.xml and updates its child accordingly (cf. D1733)
  • merges the attribute values from the hawk into it, keeping only the actor there (cf. D1774)
Test Plan

Check if nothing is overlooked and everything still works.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Mar 16 2019, 9:56 PM
Vulcan added a subscriber: Vulcan.Mar 16 2019, 9:58 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1094/display/redirect

bb accepted this revision.Mar 16 2019, 10:15 PM

Indeed inconsistent and misleading naming. Patch correct and complete, front doens't fall, also not in atlas

This revision is now accepted and ready to land.Mar 16 2019, 10:15 PM
This revision was automatically updated to reflect the committed changes.