Page MenuHomeWildfire Games

[Windows] Add information about data paths to error window
ClosedPublic

Authored by Angen on Mar 19 2019, 8:47 PM.

Details

Summary

Players reporting errors might not know where asked files are located nor data path page exists

This patch is going to point out existence of https://trac.wildfiregames.com/wiki/GameDataPaths so they can locate log files easier.

Test Plan

While here, should be added or changed some another information in error window?

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Angen created this revision.Mar 19 2019, 8:47 PM
Vulcan added a subscriber: Vulcan.Mar 19 2019, 9:22 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/lib/sysdep/os/win/wseh.cpp
|   1| /*·Copyright·(C)·2016·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2016"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/differential/1124/display/redirect

vladislavbelov added inline comments.
source/lib/sysdep/os/win/wseh.cpp
281 ↗(On Diff #7599)

I assume the original was right, you need to visit https://trac.wildfiregames.com/ and create a ticket there with information from https://trac.wildfiregames.com/wiki/GameDataPaths.

vladislavbelov added inline comments.Apr 2 2019, 11:13 PM
source/lib/sysdep/os/win/wseh.cpp
281 ↗(On Diff #7599)

I mean, a user needs to visit http://trac.wildfiregames.com/ first. We don't need to ask him to visit the http://trac.wildfiregames.com/wiki/GameDataPaths necessarily. The http://trac.wildfiregames.com/wiki/GameDataPaths just may be helpful:

"You may find paths to these files at http://trac.wildfiregames.com/wiki/GameDataPaths"

I'm worrying about repeated Please and similar calls to action.

Vulcan added a comment.Apr 3 2019, 7:16 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1160/display/redirect

vladislavbelov accepted this revision.Apr 3 2019, 7:18 PM
vladislavbelov added a reviewer: Itms.

The C++ part is clear for me.

source/lib/sysdep/os/win/wseh.cpp
284 ↗(On Diff #7658)

When we'll get complete constexpr we will be able to check the message buffer size at compile time.

This revision is now accepted and ready to land.Apr 3 2019, 7:18 PM
Itms added a comment.Apr 3 2019, 9:18 PM

The message looks good to me 👍 Maybe use https in the first URL for consistency, but that's a nitpick.

Do you want me to test on Windows @vladislavbelov?

In D1799#74045, @Itms wrote:

Do you want me to test on Windows @vladislavbelov?

As you want, I just wanted you check the text :)

Angen added a comment.Apr 3 2019, 9:45 PM

I am on windows so as you want :)

Itms accepted this revision.Apr 3 2019, 10:53 PM

Still good after testing! The text improvement is a good idea yeah 🙂

In D1799#74058, @Itms wrote:

Still good after testing! The text improvement is a good idea yeah 🙂

@Itms Will you commit it?

Itms added a comment.Apr 4 2019, 8:33 PM

If you want go ahead! Else I can commit it in an hour or two

In D1799#74092, @Itms wrote:

If you want go ahead! Else I can commit it in an hour or two

Nope, just clarified :) You're welcome to commit.

This revision was automatically updated to reflect the committed changes.