Page MenuHomeWildfire Games

acropolis → citadel (non-Greek fort), plateau (orography)
AcceptedPublic

Authored by Gallaecio on Mar 31 2019, 4:36 PM.

Details

Reviewers
Nescio
Summary

There are some unaccurate usages of the word ‘acropolis’ in the game.

An acropolis is a citadel or high fortified area of an ancient Greek city (https://www.dictionary.com/browse/acropolis). When it is not Greek, we should call it citadel (https://www.dictionary.com/browse/citadel). When we do not mean the fortress, but the high ground area, plateau is the right word for it (https://www.dictionary.com/browse/plateau).

I also considered renaming affected files accordingly, but the patch was huge and I could not upload it to Phabricator.

Reported by kingu at https://www.transifex.com/wildfire-games/0ad/translate/#gl/$/26724585?q=issue%3Aopen

Test Plan

None. It only affects user-visible strings.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7068
Build 11545: Vulcan BuildJenkins
Build 11544: arc lint + arc unit

Event Timeline

Gallaecio created this revision.Mar 31 2019, 4:36 PM
Vulcan added a subscriber: Vulcan.Mar 31 2019, 4:36 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1142/display/redirect

You're correct in stating there is a difference between "acropolis" (citadel) and "plateau" (geological feature); I can accept your changes to the "Decription": strings.
However, I disagree with your "Name:" string changes. Although acropoleis are typically Greek, the word can also be applied to similar features in similar cultures. There is no need to change the map names, therefore please revert those.

Something else, some descriptions have`\u000a\u000a`, others \n\n; I'm not sure which one is the preferred style.

binaries/data/mods/public/maps/scenarios/Necropolis.xml
43

4 → Four

Gallaecio updated this revision to Diff 7637.Apr 1 2019, 12:06 AM

Updated not to touch titles, and include the requested ‘4 → Four’ change.

Gallaecio marked an inline comment as done.Apr 1 2019, 12:07 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1145/display/redirect

Nescio accepted this revision.Apr 1 2019, 10:20 AM
This revision is now accepted and ready to land.Apr 1 2019, 10:20 AM