Page MenuHomeWildfire Games

standardized catafalque aura descriptions
ClosedPublic

Authored by Nescio on Apr 1 2019, 11:55 AM.

Details

Summary

This patch rephrases catafalque aura descriptions to an uniform standard, to ensure descriptions follow the actual modifications: [class] [change] [attributes], e.g. "Workers +15% gather speed." instead of "+15% gather rate for workers."

See also D1720, D1806, D1808.

Test Plan

Check for mistakes and omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Apr 1 2019, 11:55 AM
Nescio updated this revision to Diff 7643.Apr 1 2019, 11:57 AM
Nescio retitled this revision from standardize catafalque aura descriptions to standardized catafalque aura descriptions.
Nescio edited the summary of this revision. (Show Details)
Vulcan added a subscriber: Vulcan.Apr 1 2019, 1:42 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1147/display/redirect

Vulcan added a comment.Apr 1 2019, 1:44 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1148/display/redirect

Nescio updated this revision to Diff 7667.Apr 4 2019, 8:31 PM

Updated: food, wood, stone, metal.

Vulcan added a comment.Apr 4 2019, 8:33 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1167/display/redirect

Unnecessary and mundane changes.

Thanks for the notification, I missed that one; I'll reply over there.

Also, the question remains whether it's right to remove the history flavour sentence from these catafalque aura descriptions (other aura types don't have that).

In D1807#87716, @Nescio wrote:

Also, the question remains whether it's right to remove the history flavour sentence from these catafalque aura descriptions (other aura types don't have that).

I would not touch them as part of these standarization patches. See https://code.wildfiregames.com/D1806#inline-41422 for details.

Let's keep those sentences in the catafalque aura descriptions then for now.

Nescio updated this revision to Diff 9344.Thu, Aug 15, 1:25 PM
Nescio edited the summary of this revision. (Show Details)

Updated, keeping flavour text and capitalizing classes.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/389/display/redirect

Gallaecio accepted this revision.Fri, Aug 16, 9:29 PM
This revision is now accepted and ready to land.Fri, Aug 16, 9:29 PM
This revision was automatically updated to reflect the committed changes.