Page MenuHomeWildfire Games

Remove unused variable from ModelRenderer
ClosedPublic

Authored by Angen on Apr 3 2019, 7:30 PM.

Details

Reviewers
vladislavbelov
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22333: Removes unused variable from ModelRenderer introduced in rP11423. Found by…
Summary

Variable mdef is local and not used in whole scope.

Test Plan

:)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Angen created this revision.Apr 3 2019, 7:30 PM
Owners added a subscriber: Restricted Owners Package.Apr 3 2019, 7:30 PM
Vulcan added a subscriber: Vulcan.Apr 3 2019, 7:34 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/renderer/ModelRenderer.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2015"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/differential/1162/display/redirect

Stan added reviewers: Restricted Owners Package, vladislavbelov.Apr 3 2019, 7:38 PM
vladislavbelov added inline comments.Apr 3 2019, 8:19 PM
source/renderer/ModelRenderer.cpp
236 ↗(On Diff #7659)

It was missed since https://trac.wildfiregames.com/changeset/11423#file56.

Probably there are other misses of GetModelDef.

Angen added inline comments.Apr 3 2019, 8:42 PM
source/renderer/ModelRenderer.cpp
236 ↗(On Diff #7659)

they are used in another cases

wraitii accepted this revision.Apr 13 2019, 11:00 AM
This revision is now accepted and ready to land.Apr 13 2019, 11:00 AM
Angen added a comment.May 6 2019, 8:35 PM

@vladislavbelov do you have any objections about this diff?

This revision was automatically updated to reflect the committed changes.

Thank you for the patch!