Page MenuHomeWildfire Games

Remove unused variable from CInput
ClosedPublic

Authored by Angen on Apr 3 2019, 9:14 PM.

Details

Summary

variable SearchString is not used

Test Plan

:)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Angen created this revision.Apr 3 2019, 9:14 PM
Vulcan added a subscriber: Vulcan.Apr 3 2019, 9:16 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/gui/CInput.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/differential/1163/display/redirect

bb accepted this revision.Apr 6 2019, 4:56 PM
bb added a subscriber: bb.

That must be a copy-pasta, text.delete.right doesn't have it, so completeness in that sense

compiles, front doesn't fall => accept

This revision is now accepted and ready to land.Apr 6 2019, 4:56 PM
elexis added a subscriber: elexis.Apr 6 2019, 5:47 PM

15:34 < bb> just leaving it accepted for a short while (till tonight) in case someone wants to add something

  • One may check for other unused vars in the same file (the compiler should already be checking for that)
  • One may want to find the revision (for referencing, possible audit, revision of the underlying feature design, discovery of forgotton implementation ideas etc)

may = may chose not to

Angen added a comment.EditedApr 6 2019, 6:00 PM
In D1813#74338, @elexis wrote:

15:34 < bb> just leaving it accepted for a short while (till tonight) in case someone wants to add something

  • One may check for other unused vars in the same file (the compiler should already be checking for that)
  • One may want to find the revision (for referencing, possible audit, revision of the underlying feature design, discovery of forgotton implementation ideas etc)

may = may chose not to

I have been checking whole project for unused variables and have split revisions based on files. So no another unused variable in this file.

forgot Implementation might be to not have *pCaption but searchString directly.

Revision: rP9646

This revision was automatically updated to reflect the committed changes.