Page MenuHomeWildfire Games

Unused iterator in Xeromyces
ClosedPublic

Authored by Angen on Apr 3 2019, 9:28 PM.

Details

Summary

"std::set<std::string>::iterator it" is local variable which is never used or initialised in its scope

iterator functionality removed in rP16888

Test Plan

:)

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Angen created this revision.Apr 3 2019, 9:28 PM
Vulcan added a subscriber: Vulcan.Apr 3 2019, 9:30 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1164/display/redirect

Angen edited the summary of this revision. (Show Details)Apr 6 2019, 6:21 PM
Angen edited the summary of this revision. (Show Details)
vladislavbelov accepted this revision.Apr 7 2019, 8:21 PM

I tested the patch and it works. Since the problem is reported by cppcheck (probably by some compiler too) I don't see a reason to refactor the whole file, because it's a bit other problem.

This revision is now accepted and ready to land.Apr 7 2019, 8:21 PM
This revision was automatically updated to reflect the committed changes.

@Angen thank you for the patch!