Page MenuHomeWildfire Games

island → peninsula
ClosedPublic

Authored by Gallaecio on Apr 7 2019, 5:54 PM.

Details

Summary
Test Plan

None, only affects user-visible strings

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7130
Build 11636: Vulcan BuildJenkins
Build 11635: arc lint + arc unit

Event Timeline

Gallaecio created this revision.Apr 7 2019, 5:54 PM
Vulcan added a subscriber: Vulcan.Apr 7 2019, 5:55 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1180/display/redirect

Nescio added a comment.Apr 7 2019, 6:00 PM

However, if you open the map, you can see it's actually an island, not a peninsula:

@Nescio What would you think about calling it ‘tidal island’? (https://en.wikipedia.org/wiki/Tidal_island)

While there are no tides in 0 A.D., it should help understand why the description talks about a strip of land joining the island to the mainland.

Nescio added a comment.Aug 3 2019, 4:38 PM

Indeed, 0 A.D. doesn't have tides.
Wouldn't it be simpler and more correct to keep “island” but replace “a narrow strip of land” with “shallow water” or something?

Gallaecio updated this revision to Diff 9273.Aug 9 2019, 7:13 AM

Great idea!

Vulcan added a comment.Aug 9 2019, 7:13 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/342/display/redirect

Nescio accepted this revision.Aug 9 2019, 9:42 AM
This revision is now accepted and ready to land.Aug 9 2019, 9:42 AM
This revision was landed with ongoing or failed builds.Aug 10 2019, 11:28 AM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Aug 10 2019, 11:28 AM