Page MenuHomeWildfire Games

Replace includes uniform_foo with uniform_foo_distribution
ClosedPublic

Authored by Stan on Apr 10 2019, 8:17 PM.

Details

Reviewers
Angen
vladislavbelov
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22211: Replace includes uniform_foo with uniform_foo_distribution as it's deprecated…
Trac Tickets
#5428
Summary

See ticket

Test Plan

Check that everything works as expected.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Stan created this revision.Apr 10 2019, 8:17 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/maths/tests/test_Sqrt.h
|   1| /*·Copyright·(C)·2009·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2009"

source/graphics/ObjectBase.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2018"

source/graphics/ParticleEmitterType.cpp
|   1| /*·Copyright·(C)·2015·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2015"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/differential/1190/display/redirect

Stan updated this revision to Diff 7718.Apr 10 2019, 8:30 PM

Fix years.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1191/display/redirect

Angen accepted this revision.EditedApr 10 2019, 9:55 PM

builds, deprecated variants are replaced with valid equivalents

This revision is now accepted and ready to land.Apr 10 2019, 9:55 PM

Which version of boost starts support it?

Stan added a comment.Apr 15 2019, 7:53 AM

boost::random::uniform_int_distribution & boost::random::uniform_real_distribution<float> → 1.47 https://www.boost.org/doc/libs/1_47_0/doc/html/boost/random/uniform_int_distribution.html Before it's not documented.

vladislavbelov accepted this revision.Apr 22 2019, 11:36 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Apr 22 2019, 11:45 PM