Page MenuHomeWildfire Games

Remove Iberian walls, debug logging from Polar Sea and ignore sheep
ClosedPublic

Authored by elexis on Mar 2 2017, 6:44 PM.

Details

Summary

After three entertaining testgames on that map, we noticed few things to fix:

  • Iberians start with the full wallset, this should be reduced at least to turrets, so that their unique civ bonus is still kept without making wolf attakcs obsolete
  • Wolves focus sheep too, making them obsolete once the corrals are busy
  • mimo raised a concern on the commit as the balancing debug messages are always printed. Since balancing is a task that won't go away, I prefer to keep the message but make it optional and disabled by default. Survival of the fittest is a far more complex example and the debug messages proposed in D145 will be updated equally.
  • targetCount was reduced from 3 to 2 as wolves likely die before killing the first unit. It could be 1, but sometimes (women on remote metal mines) it is relevant.
  • The first wave starts now at minute 5, so people have more time to invest their inital wood quickly.
  • Two missing semicolons

The attacker count seems to be fine for medium mapsize. Equally to survival of the fittest the difficulty depends on the mapsize, which could be later fixed by a custom gamesetup option.

Test Plan

Start the map with Iberians and see it's still working.
Press F9 and type "Engine.SetSimRate(20);" to fast forward after building corrals.
Without the patch, wolves focus the sheep in the second wave and gather there like flies.
With the patch, the sheep are ignored.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Mar 2 2017, 6:44 PM
Hannibal_Barca accepted this revision.Mar 2 2017, 6:46 PM
This revision is now accepted and ready to land.Mar 2 2017, 6:46 PM
elexis added a comment.Mar 2 2017, 6:47 PM

That went fast. Did you test the patch too? Oversights can happen

Indeed, wolves are more fearsome this way now that they focus on units.
Iberians are now balanced, they are exposed to the attacks of wolves while still maintaining a slight advantage over enemies.
First wave at minute 5 seems better as it lets players do scouting of neighbourhood and a quick fortification of base.

elexis added a comment.Mar 2 2017, 7:08 PM

Some more consideration:

(16:56:11) elexis: Hannibal_Baraq: iber towers ok?
(16:57:51) Hannibal_Baraq: hm..
(16:57:52) Hannibal_Baraq: no
(16:58:02) Hannibal_Baraq: unfair defence vs wolves
(16:58:46) Hannibal_Baraq: also with turrets in place the wallparts are dirt cheap to build
(16:59:19) elexis: its their civs advantage
(16:59:29) elexis: and they have to buy the stone in the first place
(16:59:39) elexis: and everyone can invest into starting palisade
(16:59:54) elexis: they start on most maps with walls
(16:59:56) Hannibal_Baraq: so why can't they
(17:00:41) Hannibal_Baraq: ok...
(17:00:44) Hannibal_Baraq: turrets allowed

(18:47:29) elexis: Hannibal_Baraq: D184
(18:51:22) Hannibal_Baraq: it works
(18:51:39) Hannibal_Baraq: I think lone turrets look a bit stupid but fine

Vulcan added a subscriber: Vulcan.Mar 2 2017, 7:32 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/452/ for more details.

elexis added a comment.Mar 2 2017, 7:52 PM

Reverted the targetCount change after measuring the time. Seems we need 3ms to get all nongaia entities and 500ms to sort them by distance. Looking into using the rangemanager function for that now.
We also noticed the brennus hero gives 10 metal loot for each wolf killed but no loot for muskox.
Also wolves and most other animals except elephants should not be able to attack siege engines.

This revision was automatically updated to reflect the committed changes.