Page MenuHomeWildfire Games

Set ship status bars in parent
Needs ReviewPublic

Authored by Nescio on Apr 22 2019, 1:13 PM.

Details

Reviewers
Imarok
wraitii
Summary

Less duplication by specifying the status bar in template_unit_ship.xml rather than in its children.

Test Plan

Ought to be unproblematic.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7314
Build 11910: Vulcan BuildJenkins
Build 11909: arc lint + arc unit

Event Timeline

Nescio created this revision.Apr 22 2019, 1:13 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1253/display/redirect

Imarok requested changes to this revision.Apr 25 2019, 11:32 AM
Imarok added a subscriber: Imarok.

Seems like that won't work cause of template_unit_ship_fishing.xml

This revision now requires changes to proceed.Apr 25 2019, 11:32 AM

You're correct, currently the generic fishing boat template does not specify a status bar, which means it defaults to the values of the template_unit.xml file. If desired, I suppose I could insert those into the fishing boat to preserve its status bar size.
However, is it really important that the fishing boat has a status bar different from all other ships? Does it convey some information to the player that will be lost if it's standardized?
For comparison, without this patch:


and with implementing this patch:

elexis added a subscriber: elexis.Apr 26 2019, 3:40 PM

I guess the barsize is related to the size of the visual actor, and the big one might or might not look uglier. (Perhaps it becomes more clear if there are more ships or more units in general, but probably it's not so bad)

Well that tells us that fishing ships are intended to have a regular sized status bar, not the larger one from bigger ships. I would say make a copy of template_unit's status bars for that template and keep your change otherwise.

Personally though I'm also fine with giving the fishing ships a large bar similar to other sips.

Imho the large bar looks to big for the small fishing boat

Stan added a subscriber: Stan.EditedApr 26 2019, 5:20 PM

*@Stan wishes health would be displayed in the footprint instead.

I agree with @Imarok that the health bar looks too big for the little fishing ship. How does it look from afar ?

Nescio updated this revision to Diff 7868.Apr 26 2019, 5:40 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1293/display/redirect

More ships and from afar, current smaller status bar:


standardized status bar size:

Anyway, I've updated the patch to keep the original fishing boat status bar size.

Stan added a comment.Apr 26 2019, 6:02 PM

Ugly water is really ugly ^^"

Yeah, small is better, it gets confusing otherwise.

wraitii accepted this revision.Apr 26 2019, 7:15 PM