Page MenuHomeWildfire Games

Fix VS2013 Build
ClosedPublic

Authored by Stan on Apr 23 2019, 11:43 AM.

Details

Summary

Fix for rP22207 apparently VS2013 doesn't like implicit initialization for maps.

Test Plan

Make sure it compiles fine. You should now have 321 tests.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1260/display/redirect

Itms added inline comments.Apr 23 2019, 12:01 PM
source/simulation2/components/tests/test_HierPathfinder.h
45 ↗(On Diff #7818)

Can you use this patch opportunity to fix the unusual bracket here on function definitions? There is a few of them.

95 ↗(On Diff #7818)

I think using the brackets like this is good for the maps though.

Itms awarded a token.Apr 23 2019, 12:01 PM
Stan updated this revision to Diff 7819.Apr 23 2019, 12:28 PM
  • Fix Itms' comments.
Stan marked 2 inline comments as done.Apr 23 2019, 12:29 PM
Angen resigned from this revision.Apr 23 2019, 4:33 PM

sry 0 time now

vladislavbelov accepted this revision.Apr 23 2019, 9:58 PM

I tested and it works for me on VS2013.

P.S. Actually it's not our mistake, but a bug inside the compiler. Because it should deduce a type here AFAIK.

This revision is now accepted and ready to land.Apr 23 2019, 9:58 PM
Itms accepted this revision.Apr 23 2019, 10:49 PM

I concur 🙂 I am committing this myself now, and lifting the concern I raised.

Itms changed the repository for this revision from rDD 0 A.D. Design Document to rP 0 A.D. Public Repository.Apr 23 2019, 10:50 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Apr 23 2019, 10:56 PM