Currently all boundaries, overlays for rally points and so on are rendered even if they're not visible.
To out of frustum rendering enter Engine.GameView_SetLockCullCameraEnabled(true); and move a camera.
It looks like:
Differential D1847
Optimise out of frustum rendering of textures overlays vladislavbelov on Apr 25 2019, 1:48 AM. Authored by
Details
Currently all boundaries, overlays for rally points and so on are rendered even if they're not visible. To out of frustum rendering enter Engine.GameView_SetLockCullCameraEnabled(true); and move a camera. It looks like:
Diff Detail
Event TimelineComment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... source/graphics/Overlay.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/simulation2/components/CCmpRangeOverlayRenderer.cpp | 1| /*·Copyright·(C)·2018·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2018" source/simulation2/components/CCmpSelectable.cpp | 1| /*·Copyright·(C)·2018·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2018" source/renderer/TexturedLineRData.h | 1| /*·Copyright·(C)·2012·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2012" source/renderer/TexturedLineRData.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/simulation2/components/CCmpTerritoryManager.cpp | 1| /*·Copyright·(C)·2018·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2018" Executing section JS... Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1274/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/differential/1275/display/redirect Comment Actions What's the perf gain like ?
Comment Actions The submit time shouldn't increase and the render time should decrease a bit. Probably it won't be really visible on powerful computers. Comment Actions I think perf impact is negligible (it's definitely better, but probably not by much, and the main impact is likely a lower number of draw calls). I notice UnitRenderer seems to call Frustrum methods directly rather than calling member of Unit, maybe that could be standardised? Comment Actions Yeah, the same thoughts. It shouldn't increase and might decrease rendering time. So it's worth to not render invisible objects.
Do you mean UnitOverlay? Comment Actions Some more comments. The patch seems to work as announced. However, when pressing Tab, one can still still see lifebars, and possibly ranges if the building is close enough to the border. Maybe that should be fixed as well.
Comment Actions I'm still seeing range overlays and status bars, I'm assuming that's because you haven't changed those? If so, commit this.
|