Page MenuHomeWildfire Games

Remove 'Async' from short/long path requests names
ClosedPublic

Authored by wraitii on Wed, May 1, 10:50 AM.

Details

Reviewers
Kuba386
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22305: Remove 'Async' from short/long path requests names
Summary

D14 outtake.

Rationale: ShortPathRequest will be used as a parameter to ComputeShortPath (which avoids sending dozens of parameters) by an upcoming diff (see below), and it seems simpler to remove 'Async' to that doesn't really add much (async functions specify 'Async' already so to client-code it's the same).

Test Plan

Review changes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Wed, May 1, 10:50 AM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/simulation2/components/CCmpPathfinder.cpp
|   1| /*·Copyright·(C)·2018·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2018"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/differential/1312/display/redirect

Kuba386 accepted this revision.Sun, May 19, 4:54 PM
This revision is now accepted and ready to land.Sun, May 19, 4:54 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1502/display/redirect

wraitii updated this revision to Diff 8154.Sun, May 26, 3:10 PM

fix tests

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1507/display/redirect

This revision was automatically updated to reflect the committed changes.