Page MenuHomeWildfire Games

[gameplay] reduce Blemmye and Nuba camp building time
ClosedPublic

Authored by Nescio on May 7 2019, 10:55 AM.

Details

Reviewers
Feldfeld
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP23547: [gameplay-a24] Reduce Blemmye and Nuba camp building time
Summary

As suggested by @Philip the Swaggerless at https://wildfiregames.com/forum/index.php?/topic/25893-kushite-nomad-camps-and-nuba-village/&tab=comments#comment-374552

Currently the Kushite mercenary camps (town phase, 1000 health) have a building time of 200; this patch removes that line, so they inherit the value from template_structure_military_embassy.xml instead, which is 150. For comparison, the barracks (village phase, 2000 health, trains more units) also have a building time of 150.

Test Plan

Tiny tweak, trivial to test.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.May 7 2019, 10:55 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1335/display/redirect

Nescio added a reviewer: Restricted Owners Package.Jul 6 2019, 5:37 PM
Nescio retitled this revision from reduce Blemmye and Nuba camp building time to [gameplay] reduce Blemmye and Nuba camp building time.Dec 23 2019, 4:47 PM
Nescio removed a reviewer: borg-.Feb 7 2020, 2:48 PM
Nescio added subscribers: Sundiata, ValihrAnt, borg-.

Didn't even realise they take took longer than barracks to build, doesn't make much sense to me. It makes sense for a camp to be built faster than a pretty big stone building. Won't change how often they're used but it will make more logical sense.

Nescio added a comment.Feb 7 2020, 3:00 PM

(If you approve of the changes you can click “Add Action...” → “Accept Revision”; also applies to any other patch here on phabricator.)

Feldfeld accepted this revision.Mar 21 2020, 3:43 PM
Feldfeld added a subscriber: Feldfeld.

I agree that the build time needs to be reduced, however not sure if it should be to 100. Carthaginian embassies have 150 build time, too

This revision is now accepted and ready to land.Mar 21 2020, 3:43 PM

Didn't mean to accept btw

Stan added a subscriber: Stan.Mar 21 2020, 3:53 PM

You can also request changes :D

Stan requested changes to this revision.Mar 22 2020, 10:58 AM
This revision now requires changes to proceed.Mar 22 2020, 10:58 AM
Stan removed a reviewer: Stan.Mar 22 2020, 10:58 AM
This revision is now accepted and ready to land.Mar 22 2020, 10:58 AM
Stan requested changes to this revision.Mar 22 2020, 10:58 AM
This revision now requires changes to proceed.Mar 22 2020, 10:58 AM
This revision now requires review to proceed.Mar 22 2020, 11:09 AM
Nescio updated this revision to Diff 11516.Mar 22 2020, 11:10 AM
Nescio edited the summary of this revision. (Show Details)

150

Owners added a subscriber: Restricted Owners Package.Mar 22 2020, 11:10 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1877/display/redirect

Feldfeld accepted this revision.Mar 22 2020, 11:32 AM

I agree with the changes now.

This revision is now accepted and ready to land.Mar 22 2020, 11:32 AM
This revision was automatically updated to reflect the committed changes.