- Cleanup Included.
- Use forward declaration.
- Remove undefined behavior refs #5288.
- Use static_cast<> instead of c casts.
- null → Nullptr.
- Use Pascal case for functions.
- Make variables const.
- Remove duplication.
Details
- Reviewers
vladislavbelov Silier - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP22316: Cleanup MikktspaceWrapper.
Test with and without precompiled headers.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build failure - The Moirai have given mortals hearts that can endure.
Linter detected issues: Executing section Source... source/renderer/ModelRenderer.cpp | 1| /*·Copyright·(C)·2015·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2015" Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/differential/1350/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1351/display/redirect
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1352/display/redirect
source/renderer/MikktspaceWrap.cpp | ||
---|---|---|
65 ↗ | (On Diff #7946) | I am only thinking, should be here (and on another places as well) check if we are not out of range? |
source/renderer/MikktspaceWrap.cpp | ||
---|---|---|
65 ↗ | (On Diff #7946) | Well I guess it iterates on every face the model provides, so I don't see how it can be out of range. |
Builds with and without precompiled headers on windows.
Models and textures in game looks fine (did not expect do break anything)
source/renderer/MikktspaceWrap.cpp | ||
---|---|---|
65 ↗ | (On Diff #7946) | yes, you are right :) (mikkspace.cpp keeps them in range so not needed) |
source/renderer/MikktspaceWrap.h | ||
53 ↗ | (On Diff #7946) | maybe should be changed to javadoc style |
source/renderer/ModelRenderer.cpp | ||
142 ↗ | (On Diff #7946) | while this file has changes already, can we make ++j ( to make it consistent with rest of the file :) )? |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1355/display/redirect