Adds a new format so that axis values can have a percentage sign.
Details
Agree
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/gui/CChart.cpp | 1| /*·Copyright·(C)·2018·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2018" Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/differential/1373/display/redirect
source/gui/CChart.cpp | ||
---|---|---|
286 ↗ | (On Diff #7980) | Why 64 ? :) |
source/gui/CChart.cpp | ||
---|---|---|
286 ↗ | (On Diff #7980) | I just assumed vlad did a sane decision ;P |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1374/display/redirect
The patch looks good for me.
source/gui/CChart.cpp | ||
---|---|---|
285 ↗ | (On Diff #7981) | As far as I remember it was 64 because float fits into it with enough space (it costs 40+ bytes with a maximum number) and it's aligned by 4, though it doesn't have any advantage in comparison with 48. |
286 ↗ | (On Diff #7981) | Are you aware that static_cast<int>(99.999) is 99 and not 100? |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1401/display/redirect