Page MenuHomeWildfire Games

Whales should not block ships
ClosedPublic

Authored by elexis on Mar 4 2017, 4:39 AM.

Details

Summary

Whales blocking ships is always annoying, in particular in battles when one has to retreat, even more because they are moving and changing directions.
The only argument to not have them blocking has been that the models would overlap, which would look unrealistic as neither of both are ghosts.
However (1) the corpse does not have the blocking property but the same model and position and (2) it doesn't look that bad if you check the gifs and (3) it is not unrealistic that whales swim below ships.

Worst case mentioned by Sandarac should be this jumping animation on sicilia nomad, but it is hard to trigger since the period of overlap is very short as the whale always moves, the ship too mostly:

Other worst case mentioned by bb:

Notice with the front and rear end of the ship, collisions already occur:

Test Plan

See the patch in action on cycladic archipelago and try to produce the worst case scenario.

Notice that both properties are needed:
<element name='BlockMovement' a:help='Whether units should be allowed to walk through this entity
<element name='BlockPathfinding' a:help='Whether the long-distance pathfinder should avoid paths through this entity. This should only be set for large stationary obstructions'>"

Persuade yourself that those are all templates by searching for "<PassabilityClass>ship"

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Mar 4 2017, 4:39 AM
elexis edited the summary of this revision. (Show Details)Mar 4 2017, 4:43 AM
elexis edited the test plan for this revision. (Show Details)
elexis added reviewers: wraitii, enrique.
elexis edited the summary of this revision. (Show Details)Mar 4 2017, 5:06 AM
wraitii accepted this revision.Mar 23 2017, 3:03 PM
This revision is now accepted and ready to land.Mar 23 2017, 3:03 PM

I don't see the clipping (even in the worst case) as a big issue, it's imo one of those accepted breaks from reality from playing an RTS, and anyway trying to fix that problem would be an absolute nightmare.

We might want to lower the position of the whales (@enrique), but personally I don't really mind and it's nice to see whales breaching.

This should help, however much, with ship pathfinding, which is great.

Enrique posted in the art topic 16024-random-stuff:

I'll answer here. I agree on removing whale obstruction, but I don't consider some clipping when passing through it a important "immersion-breaking" limitation

elexis edited the summary of this revision. (Show Details)Mar 23 2017, 11:30 PM
This revision was automatically updated to reflect the committed changes.

Also the altitude seems correct for both whales, we have maps for both whales (tested them both on cycladic), the altitudes were fixed in rP13767 following an oversight in rP13749.