Differential D1883

Use arrow functions in ai filters
ClosedPublic
Actions

Authored by bb on May 13 2019, 7:46 PM.

Details

Reviewers

wraitii

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP22968: Use arrow functions in AI filters

Summary

Cleaning the filters.js file from the ai

Test Plan

Let the bots run

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bb created this revision.May 13 2019, 7:46 PM

Owners added a subscriber: Restricted Owners Package.May 13 2019, 7:46 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1392/display/redirect

Harbormaster completed remote builds in B7470: Diff 8006.May 13 2019, 10:04 PM

return can be avoided using parentheses.
Considered checking up/down/other stream?

wraitii added a reviewer: Restricted Owners Package.May 25 2019, 2:42 PM

Skip the returns as elexis said

This revision now requires changes to proceed.May 28 2019, 5:25 PM

Brackets

Up/Down: made this because I stumbled upon this when working on some other patches
Other: kindof hard to look into something without access

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1543/display/redirect

Harbormaster completed remote builds in B7669: Diff 8207.May 29 2019, 10:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2019, 4:01 PM

Closed by commit rP22968: Use arrow functions in AI filters (authored by bb). · Explain Why

This revision was automatically updated to reflect the committed changes.

bb added a commit: rP22968: Use arrow functions in AI filters.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

simulation/

ai/

common-api/

filters.js

319 lines

Diff 9914

View Options

ps/trunk/binaries/data/mods/public/simulation/ai/common-api/filters.js

Use arrow functions in ai filtersClosedPublicActions