Differential D1888

Unit Motion - remove the m_Moving variable
ClosedPublic
Actions

Authored by wraitii on May 13 2019, 9:48 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP22354: Unit Motion - remove the m_Moving variable

Summary

m_Moving is supposed to tell us whether we are trying to move or not (NB: this is different from moving, which implies our position is changing). It was used by IsMoving(), which should be renamed "HasATarget" or something in a later diff.

The variable is not necessary since having a target is equivalent, and this reduces state, so remove it.

Test Plan

Compile.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.May 13 2019, 9:48 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1399/display/redirect

Harbormaster failed remote builds in B7479: Diff 8016!May 14 2019, 12:27 AM

wraitii added a child revision: D1893: Drop an indentation level in UnitMotion.May 15 2019, 9:24 PM

Rebased for committing.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1670/display/redirect

Harbormaster completed remote builds in B7858: Diff 8397.Jun 9 2019, 5:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 9 2019, 7:04 PM

Closed by commit rP22354: Unit Motion - remove the m_Moving variable (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

simulation2/

components/

CCmpUnitMotion.cpp

18 lines

ICmpUnitMotion.h

2 lines

Diff 8401

View Options

ps/trunk/source/simulation2/components/CCmpUnitMotion.cpp