Page MenuHomeWildfire Games

Face point when calling StopMoving()
ClosedPublic

Authored by wraitii on May 13 2019, 10:43 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22355: Unit Motion - Face point when calling StopMoving()
Summary

If an external object calls StopMoving (since D1886 removed UnitMotion calling that on itself), we should point towards the target if that was wanted. This avoids doing it in a bunch of different places.

Test Plan

Check behaviour in game, notice that units are oriented correctly.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.May 13 2019, 10:43 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1400/display/redirect

wraitii updated this revision to Diff 8398.Jun 9 2019, 5:27 PM

Rebased for committing.

Vulcan added a comment.Jun 9 2019, 5:33 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1671/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Jun 9 2019, 7:06 PM
This revision was automatically updated to reflect the committed changes.