Page MenuHomeWildfire Games

Drop an indentation level in UnitMotion
ClosedPublic

Authored by wraitii on May 15 2019, 9:19 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22360: Drop an indentation level in UnitMotion.
Summary

Completely consequence-less by itself, this will make later changes neater.

Test Plan

Look at all that un-necessary indenting.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.May 15 2019, 9:19 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1410/display/redirect

wraitii updated this revision to Diff 8032.May 15 2019, 10:18 PM

slightly better code organisation.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1411/display/redirect

wraitii updated this revision to Diff 8072.May 19 2019, 4:45 PM

Updated

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1448/display/redirect

wraitii updated this revision to Diff 8123.May 25 2019, 4:31 PM

Rebased

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1482/display/redirect

wraitii updated this revision to Diff 8399.Jun 9 2019, 5:31 PM

Rebased for committing

Vulcan added a comment.Jun 9 2019, 5:33 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1672/display/redirect

Angen added a subscriber: Angen.Jun 9 2019, 6:47 PM
Angen added inline comments.
source/simulation2/components/CCmpUnitMotion.cpp
881 ↗(On Diff #8399)

this continue is not needed, could be removed please?

928 ↗(On Diff #8399)

maybe remove this line

wraitii added inline comments.Jun 9 2019, 6:56 PM
source/simulation2/components/CCmpUnitMotion.cpp
881 ↗(On Diff #8399)
928 ↗(On Diff #8399)
wraitii updated this revision to Diff 8413.Jun 10 2019, 1:08 PM

This time should apply neatly.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1679/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Jun 10 2019, 7:15 PM
This revision was automatically updated to reflect the committed changes.