Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP22364: UnitMotion - Split Move() into several functions
Compile.
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 7586 Build 12367: Vulcan Build Jenkins Build 12366: arc lint + arc unit
Event Timeline
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/differential/1415/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/differential/1452/display/redirect
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/differential/1483/display/redirect
source/simulation2/components/CCmpUnitMotion.cpp | ||
---|---|---|
853 | please add space after pos.X, | |
959 | maybe use negation to return true as early return and you do not need if {} else {} | |
985 | negation for early return and remove if else ? | |
1010 | It does not looks like obstruction required handling here, we just stopped as we are close no? |
source/simulation2/components/CCmpUnitMotion.cpp | ||
---|---|---|
1010 | ClosEnoughFromDestinationToStop is more liberal than the range checks. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1687/display/redirect