Page MenuHomeWildfire Games

UnitMotion - Change "Possibly At Destination" logic.
ClosedPublic

Authored by wraitii on May 15 2019, 10:56 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22366: UnitMotion - Change "Possibly At Destination" logic.
Summary

PossiblyAtDestination checks if we have (probably) arrived in three ways:

  • if we are a formation member: is the formation controller is arrived
  • if we aren't, and we are not following a moving entity, assume out of waypoint == at destination
  • if we aren't, and we are following a moving entity, check if need to move again.

This logic is weird and a bit broken, and instead we should use range checks from D981.
It also requires us to be moving to make sense, which prevents removing m_State.

Test Plan

Compile, run the game and check out unit behaviour.

Diff Detail

Event Timeline

wraitii created this revision.May 15 2019, 10:56 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1417/display/redirect

wraitii updated this revision to Diff 8078.May 19 2019, 4:53 PM
wraitii edited the summary of this revision. (Show Details)

Updated and fixed

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1454/display/redirect

wraitii updated this revision to Diff 8432.Jun 11 2019, 8:46 PM

Rebased for committing.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1691/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Jun 11 2019, 9:52 PM
This revision was automatically updated to reflect the committed changes.