Differential D1912

replace , with .
ClosedPublic
Actions

Authored by Nescio on May 21 2019, 5:16 PM.

Details

Reviewers

Imarok

Commits

rP22293: Replace , with . in an AI's chat sentence

Summary

Currently one of the AI's sentences ends with a comma; this patch corrects it into a full stop.

Test Plan

Ought to be unproblematic.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 7557
Build 12322: Vulcan Build	Jenkins
Build 12321: arc lint + arc unit

Event Timeline

Nescio created this revision.May 21 2019, 5:16 PM

Owners added a subscriber: Restricted Owners Package.May 21 2019, 5:16 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1466/display/redirect

Harbormaster completed remote builds in B7557: Diff 8095.May 21 2019, 5:21 PM

Slipped through in rP19194

This revision is now accepted and ready to land.May 21 2019, 5:26 PM

thanks for the patch

Closed by commit rP22293: Replace , with . in an AI's chat sentence (authored by Imarok). · Explain WhyMay 21 2019, 7:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

simulation/

ai/

petra/

chatHelper.js

2 lines

Diff 8095

View Options

binaries/data/mods/public/simulation/ai/petra/chatHelper.js

replace , with .ClosedPublicActions